Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATMdriver to request_firmware()

[David Miller]

From: "Chas Williams (CONTRACTOR)" <chas@xxxxxxxxxxxxxxxx>
Date: Mon, 30 Jun 2008 12:10:47 -0400

> In message <1214837678.10393.345.camel@xxxxxxxxxxxxxxxxxx>,David Woodhouse writ
> es:
> >> i removed the #ifdef's from around MODULE_LICENSE().  there shouldnt
> >> be any need for #ifdef's around MODULE_FIRMWARE() either.
> >
> >Unless you put #ifdef CONFIG_SBUS around the
> >MODULE_FIRMWARE("sba200e_ecd.bin") you will be requesting that firmware
> >even on non-sbus machines. Likewise little-endian vs. big-endian on PCI.
> 
> does it?  i was under the impression that MODULE_FIRMWARE() just
> provides a hint that modinfo can read.  request_firmware() still
> the requestor for the firmware image.

And also, there are systems with both PCI and SBUS so we should
make sure we handle that properly here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/