Re: [PATCH 3/5] MMC: fix sdio_io sparse errors

From: Marcel Holtmann
Date: Mon Jun 30 2008 - 21:54:53 EST


Hi Tomas,

> if (blksz == 0) {
> - blksz = min(min(
> - func->max_blksize,
> - func->card->host->max_blk_size),
> - 512u);
> + blksz = min(func->max_blksize, func->card->host->max_blk_size);
> + blksz = min(blksz, 512u);
> }

I agree that your version is more readable, but I would be still
interested in which sparse error this fixes.

Other than that the patch looks good.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/