Re: [PATCH] fix rcu vs hotplug race

From: Dhaval Giani
Date: Tue Jul 01 2008 - 02:29:31 EST


On Tue, Jul 01, 2008 at 08:16:01AM +0200, Ingo Molnar wrote:
>
> * Gautham R Shenoy <ego@xxxxxxxxxx> wrote:
>
> > So, it's the design of stop_machine() that's preventing someone from
> > updating the cpu_online_map while force_quiescent_state() is
> > performing the cpu_is_online() check. Becase we always call
> > force_quiescent_state() with irqs disabled :)
>
> Paul, do you concur? I'll apply the commit in the form below to
> tip/core/urgent if Paul agrees.
>
> Ingo

Ingo,

I believe Gautham's fix at http://lkml.org/lkml/2008/6/27/9 is better
and also explains it better.

Thanks.
--
regards,
Dhaval
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/