Re: [PATCH -next] bug.h: add empty warn_on_slowpath() for CONFIG_BUG=n

From: Randy Dunlap
Date: Tue Jul 01 2008 - 16:24:04 EST


--- Original Message ---
> On Tue, 1 Jul 2008 10:33:39 -0700
> Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
>
> > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> >
> > Add an empty function for warn_on_slowpath() when CONFIG_BUG=n so that
> > this build error does not happen:
> >
> > linux-next-20080701/drivers/acpi/utilities/utmisc.c: In function 'acpi_ut_error':
> > linux-next-20080701/drivers/acpi/utilities/utmisc.c:1028: error: implicit declaration of function 'warn_on_slowpath'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> > ---
> > include/asm-generic/bug.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > --- linux-next-20080701.orig/include/asm-generic/bug.h
> > +++ linux-next-20080701/include/asm-generic/bug.h
> > @@ -81,4 +81,9 @@ extern void warn_on_slowpath(const char
> > # define WARN_ON_SMP(x) do { } while (0)
> > #endif
> >
> > +#ifndef __ASSEMBLY__
> > +static inline void warn_on_slowpath(const char *file, const int line)
> > +{ }
> > +#endif
> > +
> > #endif
> >
>
> This looks like a needed-in-mainline fix? or is there something
> in linux-next which causes the bug?

Looks like only linux-next has this code:

> > linux-next-20080701/drivers/acpi/utilities/utmisc.c: In function 'acpi_ut_error':
> > linux-next-20080701/drivers/acpi/utilities/utmisc.c:1028: error: implicit declaration of function 'warn_on_slowpath'


~Randy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/