Re: [patch 1/9] TTY: fix for tty operations bugs

From: S.ÃaÄlar Onur
Date: Wed Jul 02 2008 - 05:58:37 EST


Hi Greg;

01 Tem 2008 Sal tarihinde, Greg KH ÅunlarÄ yazmÄÅtÄ:
> On Tue, Jul 01, 2008 at 08:18:59AM -0700, Greg KH wrote:
> > 2.6.25-stable review patch. If anyone has any objections, please let us know.
> >
> > ------------------
> >
> > From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> >
> > This is fixed with the recent tty operations rewrite in mainline in a
> > different way, this is a selective backport of the relevant portions to
> > the -stable tree.
> >
> > Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >
> > ---
> > drivers/net/hamradio/6pack.c | 2 ++
> > drivers/net/hamradio/mkiss.c | 8 ++++++--
> > drivers/net/irda/irtty-sir.c | 4 +++-
>
> Hm, there are a few build errors with this patch in these two files,
> I'll go respin it and do a new -rc release...
>
> Sorry for missing this before.

I still have following build error

[...]
drivers/net/hamradio/mkiss.c: In function 'ax_xmit':
drivers/net/hamradio/mkiss.c:548: error: 'struct tty_struct' has no member named 'drivers'
drivers/net/hamradio/mkiss.c:549: error: 'struct tty_struct' has no member named 'chars_in_buffer'
drivers/net/hamradio/mkiss.c:552: warning: format '%s' expects type 'char *', but argument 3 has type 'int'
drivers/net/hamradio/mkiss.c:552: error: expected ';' before ')' token
drivers/net/hamradio/mkiss.c:552: error: expected statement before ')' token

*** 4 errors, 1 warnings
[...]

after your

commit bdd6248729d1f4a75e4623bce4f9c7737753b712
Author: Greg Kroah-Hartman <gregkh@xxxxxxx>
Date: Tue Jul 1 09:44:04 2008 -0700

fix build error in tty patch

commit to stable-queue

Cheers
--
S.ÃaÄlar Onur <caglar@xxxxxxxxxxxxx>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/