Re: WAN: Remove dead code from wanmain.c, CONFIG_WANPIPE_MULTPPP doesn't exist

From: Krzysztof Halasa
Date: Wed Jul 02 2008 - 16:21:49 EST


Adrian Bunk <bunk@xxxxxxxxxx> writes:

>> -#ifdef CONFIG_WANPIPE_MULTPPP
>> - pppdev = kzalloc(sizeof(struct ppp_device), GFP_KERNEL);
>> - err = -ENOBUFS;
>> - if (pppdev == NULL)
>> - goto out;
>> - pppdev->dev = kzalloc(sizeof(struct net_device), GFP_KERNEL);
>> - if (pppdev->dev == NULL) {
>> - kfree(pppdev);
>> - err = -ENOBUFS;
>> - goto out;
>> - }
>> - err = wandev->new_if(wandev, (struct net_device *)pppdev, cnf);
>> - dev = pppdev->dev;
>> -#else
>> printk(KERN_INFO "%s: Wanpipe Mulit-Port PPP support has not been compiled in!\n",
>> wandev->name);
>
> The printk() also needs some updating.

Agreed.
--
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/