Re: [PATCH 1/2] Support for the at91sam9g20 : Atmel 400Mhz ARM 926ej-sSOC

[Sedji Gaouaou]

Hi Andrew,
>   
> > +/*
> > + * MCI (SD/MMC)
> > + */
> > +static struct at91_mmc_data __initdata ek_mmc_data = {
> > +	.slot_b		= 1,
> > +	.wire4		= 1,
> > +//	.det_pin	= ... not connected
> > +//	.wp_pin		= ... not connected
> > +//	.vcc_pin	= ... not connected
> >     
>
> Please make these a proper comment, preferably inside the comment before
> the structure.  C++ comments are frowned upon in the kernel's source.
>
>   
I would like to know what do you suggest about this comment? Indeed we 
already use this kind of comments, for instance in board-sam9260ek.c. I 
don't mind changing it into the proper comment form, but I would like to 
know first what do you suggest.

Regards,
Sedji

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/