Re: [Bug 10868] Oops on loading ipaq module since 2.6.26, prevents use of device

From: Oliver Neukum
Date: Thu Jul 03 2008 - 10:26:34 EST


Am Donnerstag 03 Juli 2008 16:20:30 schrieb Adrian Bunk:
> On Thu, Jul 03, 2008 at 04:08:44PM +0200, Oliver Neukum wrote:
> > Am Donnerstag 03 Juli 2008 10:57:33 schrieb Adrian Bunk:

> > > --- a/drivers/usb/serial/ipaq.c
> > > +++ b/drivers/usb/serial/ipaq.c
> > > @@ -571,9 +571,9 @@ static struct usb_serial_driver ipaq_device = {
> > > .usb_driver = &ipaq_driver,
> > > .id_table = ipaq_id_table,
> > > .num_interrupt_in = NUM_DONT_CARE,
> > > - .num_bulk_in = 1,
> > > - .num_bulk_out = 1,
> > > - .num_ports = 1,
> > > + .num_bulk_in = NUM_DONT_CARE,
> > > + .num_bulk_out = NUM_DONT_CARE,
> >
> > This is good.
>
> These fields are removed by a later commit in 2.6.26... 8-)

Well, NUM_DONT_CARE is default, so it makes no difference, but a comment
would have been nice.

Regards
Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/