Re: slub: Do not use 192 byte sized cache if minimum alignment is128 byte

From: Yoichi Yuasa
Date: Thu Jul 03 2008 - 21:05:39 EST


On Thu, 3 Jul 2008 18:37:52 +0300
"Pekka Enberg" <penberg@xxxxxxxxxxxxxx> wrote:

> On Thu, Jul 3, 2008 at 5:14 PM, Christoph Lameter
> <cl@xxxxxxxxxxxxxxxxxxxx> wrote:
> > The 192 byte cache is not necessary if we have a basic alignment of 128
> > byte. If it would be used then the 192 would be aligned to the next 128 byte
> > boundary which would result in another 256 byte cache. Two 256 kmalloc caches
> > cause sysfs to complain about a duplicate entry.
> >
> > MIPS needs 128 byte aligned kmalloc caches and spits out warnings on boot without
> > this patch.
> >
> > Signed-off-by: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>
>
> Looks good to me. Yoichi, did you have the chance to test this?

I've already done.
It has no problem.

Yoichi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/