Re: [PATCH -mm] documentation: update CodingStyle tips for Emacsusers

From: Jonathan Corbet
Date: Fri Jul 04 2008 - 15:42:18 EST


On Fri, 04 Jul 2008 19:52:16 +0200
Johannes Weiner <hannes@xxxxxxxxxxxx> wrote:

> +(add-hook 'c-mode-hook
> + (lambda ()
> + (let ((filename (buffer-file-name)))
> + ;; Enable kernel mode for the appropriate files
> + (when (and file
> + (string-match "/usr/src/linux" filename))

Shouldn't that be "(and filename ..." rather than "file"?

A test for /usr/src/linux seems misplaced, though; I don't think a
whole lot of people keep their kernel trees there anymore. There must
be a better heuristic one can use to figure out whether a kernel source
file is being edited.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/