On Thursday 26 June 2008 12:51, Jeremy Fitzhardinge wrote:
Peter Zijlstra wrote:
On Mon, 2008-06-23 at 13:45 -0700, Christoph Lameter wrote:Thomas Friebel presented results at the Xen Summit this week showing
On Mon, 23 Jun 2008, Peter Zijlstra wrote:The trouble with ticket locks is that they can't handle waiters going
True. But maybe we can make these fairness schemes more generic so thatIt is good that the locks are build with _trylock and _can_lockWell, good and bad, the turn side is that fairness schemes like ticket
because then we can reenable interrupts while spinning.
locks are utterly defeated.
they can go into core code?
away - or in this case getting preempted by irq handlers. The one who
took the ticket must pass it on, so if you're preempted it just sits
there being idle, until you get back to deal with the lock.
But yeah, perhaps another fairness scheme might work in the generic
code..
that ticket locks are an absolute disaster for scalability in a virtual
environment, for a similar reason. It's a bit irritating if the lock
holder vcpu gets preempted by the hypervisor, but its much worse when
they release the lock: unless the vcpu scheduler gives a cpu to the vcpu
with the next ticket, it can waste up to N timeslices spinning.
I didn't realise it is good practice to run multiple "virtual CPUs"
of the same guest on a single physical CPU on the host...
I'm experimenting with adding pvops hook to allow you to put in new
spinlock implementations on the fly. If nothing else, it will be useful
for experimenting with different algorithms. But it definitely seems
like the old unfair lock algorithm played much better with a virtual
environment, because the next cpu to get the lock is the next one the
scheduler gives time, rather than dictating an order - and the scheduler
should mitigate the unfairness that ticket locks were designed to solve.
... if it is good practice, then, virtualizing spinlocks I guess is
reasonable. If not, then "don't do that". Considering that probably
many bare metal systems will run pv kernels, every little cost adds
up