Re: [PATCH] fix build error of driver/mfd/tc6393xb.c

From: David Brownell
Date: Mon Jul 07 2008 - 12:19:25 EST


On Monday 07 July 2008, Takashi Iwai wrote:
>
> > The most natural fix is to have the Kconfig for PPC_MPC52xx
> > select both GENERIC_GPIO and HAVE_GPIO_LIB.
>
> Yes.  I, however, still feel uneasy by the fact that the combination
> GENERIC_GPIO=n and HAVE_GPIO_LIB=y doesn't work.  We should either fix
> it to work or disallow the combination.

As in, HAVE_GPIO_LIB depends on GENERIC_GPIO? Fine with me;
but I'm not sure that would work. Won't Kconfig gleefully let
the "select" succeed but not select what it depends on?

We already "disallow" that combination ... but we lack any
automated way to enforce that.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/