Re: [RFC 06/11] remove CONFIG_KMOD from fs

[Johannes Berg]

On Tue, 2008-07-08 at 22:57 +0300, Adrian Bunk wrote:
> On Tue, Jul 08, 2008 at 07:00:21PM +0200, Johannes Berg wrote:
> >...
> > --- everything.orig/fs/nls/nls_base.c	2008-07-08 18:32:40.000000000 +0200
> > +++ everything/fs/nls/nls_base.c	2008-07-08 18:34:44.000000000 +0200
> >...
> > @@ -216,15 +214,13 @@ static struct nls_table *find_nls(char *
> >  struct nls_table *load_nls(char *charset)
> >  {
> >  	struct nls_table *nls;
> > -#ifdef CONFIG_KMOD
> >  	int ret;
> > -#endif
> 
> That gives an "unused variable" gcc warning with CONFIG_MODULES=n.

Actually, would anyone object to removing the printk and just using
try_then_request_module?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part