Re: [PATCH] padlock: don't whinge when loaded on a non-VIA cpu

[Rik van Riel]

On Tue, 8 Jul 2008 15:37:41 -0400
Kyle McMartin <kyle@xxxxxxxxxxx> wrote:

> +	if (!((boot_cpu_data.x86_vendor == X86_VENDOR_CENTAUR) &&
> +	     (boot_cpu_data.x86 >= 6)))	/* only on VIA C3 and above */
> +		return -ENODEV;

Why add this?

>  	if (!cpu_has_xcrypt) {
>  		printk(KERN_ERR PFX "VIA PadLock not detected.\n");
>  		return -ENODEV;

When you could simply delete the printk lines?

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/