Re: [patch 19/26] x64, x2apic/intr-remap: introcude self IPI to genapicroutines

From: Mike Travis
Date: Thu Jul 10 2008 - 22:29:20 EST


Eric W. Biederman wrote:
>> Index: tree-x86/include/asm-x86/hw_irq.h
>> ===================================================================
>> --- tree-x86.orig/include/asm-x86/hw_irq.h 2008-07-10 09:51:45.000000000 -0700
>> +++ tree-x86/include/asm-x86/hw_irq.h 2008-07-10 09:52:24.000000000 -0700
>> @@ -73,7 +73,9 @@
>> #endif
>>
>> /* IPI functions */
>> +#ifdef CONFIG_X86_32
>> extern void send_IPI_self(int vector);
>> +#endif
>> extern void send_IPI(int dest, int vector);
>
> Cute undoing unification.
>
> Eric

On a similar subject I would really like to change the send_IPI_mask to pass a
pointer to the cpumask_t arg:

void (*send_IPI_mask)(cpumask_t mask, int vector);


This bloats the stack by 512 bytes and seemingly is called by some fairly
nested routines. Any opinions?

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/