Re: [tpmdd-devel] Patch for Broadcom TPM TIS device HID

From: Rajiv Andrade
Date: Sat Jul 12 2008 - 13:47:07 EST



On Fri, 2008-07-11 at 12:16 -0700, Andrew Morton wrote:
> On Wed, 09 Jul 2008 21:34:23 -0300 Rajiv Andrade <srajiv@xxxxxxxxxxxxxxxxxx> wrote:
>
> > This depends on patch posted with "[PATCH] tpm: add Intel TPM TIS device HID" subject.
> >
> > From: LE DISEZ Erwan <eledisez@xxxxxxxxxxxxxx>
> > Subject: add Broadcom TPM TIS device HID
> >
> > Signed-off-by: Rajiv Andrade <srajiv@xxxxxxxxxxxxxxxxxx>
> > ---
> > drivers/char/tpm/tpm_tis.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> > index c7a977b..ed1879c 100644
> > --- a/drivers/char/tpm/tpm_tis.c
> > +++ b/drivers/char/tpm/tpm_tis.c
> > @@ -622,6 +622,7 @@ static struct pnp_device_id tpm_pnp_tbl[] __devinitdata = {
> > {"ATM1200", 0}, /* Atmel */
> > {"IFX0102", 0}, /* Infineon */
> > {"BCM0101", 0}, /* Broadcom */
> > + {"BCM0102", 0}, /* Broadcom */
> > {"NSC1200", 0}, /* National */
> > {"ICO0102", 0}, /* Intel */
> > /* Add new here */
>
> Thanks. I'll see if we can squeeze this into 2.6.26.
>
> I'm a bit confused over who wrote the patch? Your changelog implies it
> was LE DISEZ Erwan <eledisez@xxxxxxxxxxxxxx>. Is that correct?

ïYes, it was him, I just added the Signed-off-by that he didn't and made it apply
cleanly after "[PATCH] tpm: add Intel TPM TIS device HID".

>
> Also: Debora and Rajiv, could we please get your email addresses
> into ./MAINTAINERS? At present all we have is
>
> TPM DEVICE DRIVER
> P: Debora Velarde
> P: Rajiv Andrade
> M: tpmdd-devel@xxxxxxxxxxxxxxxxxxxxx
> W: http://tpmdd.sourceforge.net
> P: Marcel Selhorst
> M: tpm@xxxxxxxxxxxx
> W: http://www.prosec.rub.de/tpm/
> L: tpmdd-devel@xxxxxxxxxxxxxxxxxxxxx
> S: Maintained

Sure!
>
> (pls fix the whitespace there too!)

My fault. I'd already submitted a patch correcting this, but I'm going to submit a new one with both fixes.

Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/