Re: Prosaic firmware issues
From: David Woodhouse
Date: Wed Jul 16 2008 - 01:54:42 EST
On Tue, 2008-07-15 at 18:45 -0700, Linus Torvalds wrote:
> On Wed, 16 Jul 2008, Alexey Dobriyan wrote:
> > Could somebody from firmware people fix boring stuff, please:
> > 1) after allyesconfig build, git-status show plenty of crap:
> Something like the appended, perhaps?
> (I'm not going to commit it, I want some firmware person to double-check
Generally sane, but wants a few more things added.
> > 2) after "make mrproper" after allyesconfig, some files aren't removed,
> > use "git-ls-files -o" to see them.
> Ok, that needs some Makefile magic. git magic I can do.
Ah, that's caused by a stray := where there should be a +=, so the
firmware files listed before that get dropped from the list of files to
Alexey, thanks for the report. Please could you verify that this fixes
it for you?
Subject: Fix 'make clean' and .gitignore for firmware/ directory.
Provide a .gitignore file, and fix a typo which prevented some of the
generated binary files from being removed on 'make clean'.
Signed-off-by: David Woodhouse <David.Woodhouse@xxxxxxxxx>
diff --git a/firmware/.gitignore b/firmware/.gitignore
new file mode 100644
@@ -0,0 +1,6 @@
diff --git a/firmware/Makefile b/firmware/Makefile
index 981bd52..55ca321 100644
@@ -73,7 +73,7 @@ fw-shipped-$(CONFIG_USB_SERIAL_KEYSPAN_USA28X) += keyspan/usa28x.fw
fw-shipped-$(CONFIG_USB_SERIAL_KEYSPAN_USA49W) += keyspan/usa49w.fw
fw-shipped-$(CONFIG_USB_SERIAL_KEYSPAN_USA49WLC) += keyspan/usa49wlc.fw
-fw-shipped- := keyspan/mpr.fw keyspan/usa18x.fw keyspan/usa19.fw \
+fw-shipped- += keyspan/mpr.fw keyspan/usa18x.fw keyspan/usa19.fw \
keyspan/usa19qi.fw keyspan/usa19qw.fw keyspan/usa19w.fw \
keyspan/usa28.fw keyspan/usa28xa.fw keyspan/usa28xb.fw \
keyspan/usa28x.fw keyspan/usa49w.fw keyspan/usa49wlc.fw
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/