Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver

From: Roland Dreier
Date: Wed Jul 16 2008 - 12:36:39 EST


> Output of checkpatch (scripts/checkpatch.pl in kernel source).
> Personally, I am not a whitespace bigot, and don't think
> all the warnings in checkpatch have to be fixed.
>
> ----------
> ERROR: patch seems to be corrupt (line wrapped?)
> #121: FILE: drivers/net/atl1e/atl1e.h:9:
> ree
>
> WARNING: space prohibited between function name and open parenthesis '('
> #212: FILE: drivers/net/atl1e/atl1e.h:97:
> + _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\

It's kind of pointless to run checkpatch on a corrupted patch (the email
was quoted-printable and you didn't decode it back to text). Of course
it's also better to send non-mangled patches.

- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/