Re: [GIT PULL] MMC updates for 2.6.26
From: Pierre Ossman
Date: Wed Jul 16 2008 - 18:41:48 EST
On Wed, 16 Jul 2008 15:16:26 -0700 (PDT)
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 15 Jul 2008, Pierre Ossman wrote:
> > 45 files changed, 6054 insertions(+), 1320 deletions(-)
> If you had done the "--summary", you'd also have seen these bogus:
> mode change 100644 => 100755 drivers/mmc/core/sdio_io.c
> mode change 100644 => 100755 include/linux/mmc/sdio_func.h
> I have no idea why you think those things should be executable, but it
> happened in commit 6d37333163025b46afbcad434ec9a5f2e88e7254 ("mmc: fix
> sdio_io sparse errors").
Ouch. It was in the patch submitted to me, but I overlooked the mode
changes there. I wasn't fully aware git could express such things in
the patches. :)
> Anyway, there's a reason why I ask people to use
> --diffstat --summary -M
> when generating the report. This is just part of it.
> I fixed it up in the merge, so it's ok in my tree, but I thought I'd point
> it out.
Thanks. I have changed my scripts and hopefully I'll notice such
silliness in the future.
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
Description: PGP signature