Alexey Starikovskiy wrote:Not so, there are two polls in ec.c, first is poll for change in status register,Hi Alan,Vacuously so.
Could you please test if your patch works with the last patch in #10919?
My patch still applies, but #10919 makes it obsolete.
My patch fixed a
bug that shows up in polling mode. #10919 kills polling mode.
The notion of queue in embedded controller is new, it was never mentioned in
I've tested v2.6.26 + #10919 and it works fine (except for spamming the
kernel log - please read my Bugzilla comment).
It appears that interrupt mode suffered from a race which is very
similar to my original problem. If two GPE interrupts arrive before the
workqueue runs, then the second interrupt will be ignored because
EC_FLAGS_QUERY_PENDING is still set. This will happen with any EC if
interrupts are very close together, right?
I think, this is not a theoretical problem, but the problem we've tried to solve in
I think my patch also fixes this theoretical problem.
But I'd ratherSee above, I still disable EC GPE for the time than we have pending query,
you took over on this. I was already confused by ec.c in v2.6.26, and
with #10919 I understand it even less. E.g. why is
ec_switch_to_poll_mode() still present; what does it do now do_ec_poll()
Well, with this patch of yours, I guess, we will not have too many problems in EC left :-)
I'm happy to work on this with you, but I'd need to be able understand
the code first :-(.