Re: [PATCH 2/2] signals: replace p->pid == 1 check with a check for task_child_reaper
From: Eric W. Biederman
Date: Thu Jul 17 2008 - 14:52:50 EST
"Daniel Hokka Zakrisson" <daniel@xxxxxxxxx> writes:
> Eric W. Biederman wrote:
>> Daniel Hokka Zakrisson <daniel@xxxxxxxxx> writes:
>>> p->pid == 1 is insufficient when there are multiple pid namespaces.
>>> Instead, check whether the task is in the current task's
>>> child reaper's thread group.
>> We should just drop the check for init as it is redundant.
Sorry that was a half truth. Outside of the context of pid namespaces it is true.
In the context of pid namespaces it is false because we haven't merged the patches
to drop signals from inside the pid namespace on the way to init.
So it is a check that _should_ be redundant.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/