Re: Please pull ACPI updates
From: Ray Lee
Date: Thu Jul 17 2008 - 15:11:44 EST
On Thu, Jul 17, 2008 at 9:23 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> Linus Torvalds wrote:
>> But I *really* hate pulling from somebody, and seeing commit dates that
>> are from five minutes ago, and based on something that I had just pushed
>> out (which was essentially the case for this round of ACPI changes).
>> That literally shows that the code was hardly tested _at_all_ in that
>> exact configuration. It may have gotten testing based on some earlier
>> kernel version, but then it very clearly got rebased (or just quilt
>> imported) on top of a totally new kernel base, and was not tested in that
>> version very much if at all.
> Hmm, perhaps I'm thick, but for me the only difference seems to be
> that the submitter does the merge that you would do (and safes
> himself a yelling at if it doesn't build or crashes at boot or similar...).
> In both cases there's a "untested in that configuration" end configuration
> in the end, but there's nothing much that can be done against it,
> can't it?
It matters to us end-testers when we do a git bisect. If you leave the
history intact and let the merging happen at Linus' end (or, at least
at merge time), then there is a point in history of your tree that
someone (or git bisect) can check out and try, validating the patch,
and therefore fingering a failed merge.
It's the difference between having tested patches and an untested
merge, or untested new patches and an untested merge. Your point is
the end result is untested either way. The other way to look at it is
*how much* untested history ends up in the tree. In Linus' version,
just the point from the merge onward is untested. In your version,
everything is new.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/