Re: [git patches] Ocfs2 and Configfs updates for 2.6.27
From: Joel Becker
Date: Thu Jul 17 2008 - 17:24:21 EST
On Thu, Jul 17, 2008 at 11:01:40AM -0700, Linus Torvalds wrote:
> .. I really dislike how this was done.
> This commit:
> 11c3b79218390a139f2d474ee1e983a672d5839a ("configfs: Allow ->make_item()
> and ->make_group() to return detailed errors.")
> is just ugly. Returning one value by passing a pointer to a pointer, and
> the error value by returning an 'int' errno is _not_ how we do things in
> the kernel.
See, I coded it up with PTR_ERR() first, and everyone I showed
it to said "I hate PTR_ERR()!".
> I pulled it, but I want to register my protest.
I wish you hadn't, because it won't be to difficult to go back
to PTR_ERR(). However, don't revert it - that affects some of the
follow-on patches that were affected by the change.
I'll spin up a new PTR_ERR() change. I have some more cleanups
coming too, they need to finish their time in linux-next.
"The cynics are right nine times out of ten."
- H. L. Mencken
Principal Software Developer
Phone: (650) 506-8127
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/