Re: [PATCH 1/7] dynamic debug v2 - infrastructure
From: Greg KH
Date: Thu Jul 17 2008 - 19:40:50 EST
On Fri, Jul 18, 2008 at 12:56:11AM +0200, Dominik Brodowski wrote:
> On Thu, Jul 17, 2008 at 03:32:22PM -0700, Greg KH wrote:
> > > that is correct. any callers of dev_dbg() don't have to do anything. its really
> > > only the more complex debugging, where there are flags or levels that need to
> > > make adjustments to work with the new infrastructure.
> > For this reason alone, I see no reason why your patch should not be
> > merged today. You don't need the other subsystems at this point in time
> > in my opinion, it's benifit is huge already.
> not to object to this statement, but:
> what about the user-visible interface? currently, it's based around one big
> debugfs file. What about doing
By virtue of this being in debugfs, we can change the user interface
around as time goes on if we want to with no ill side affects. :)
> instead, or even
I like this as that is what a number of current modules do (usb-serial
drivers), but you have to be careful about the module parameter
namespace to not get collisions here with existing "debug" files.
So for now, I recommend staying in debugfs, it makes more sense.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/