Re: [PATCH 1/8] cpumask: Replace cpumask_of_cpu with cpumask_of_cpu_ptr

From: Rusty Russell
Date: Fri Jul 18 2008 - 01:30:27 EST


On Wednesday 16 July 2008 07:14:30 Mike Travis wrote:
> * This patch replaces the dangerous lvalue version of cpumask_of_cpu
> with new cpumask_of_cpu_ptr macros. These are patterned after the
> node_to_cpumask_ptr macros.

Hi Mike,

Should we just put cpumask_of_cpu_map[] in generic code and then have
cpumask_of_cpu() always return a cpumask_t pointer? These macros which
declare things which may be one of two types is a real penalty for code
readability.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/