Re: [PATCH] (updated, rolled up) make section names compatiblewith -ffunction-sections -fdata-sections

From: Ingo Molnar
Date: Fri Jul 18 2008 - 04:50:39 EST



* Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx> wrote:

> Hi Andrew,
>
> Here is the update against current Linus tree,
> rolled up into one patch.
>
> James Bottomley suggested a different naming scheme:
> instead of swapping parts (.text.head -> .head.text),
> prepend .kernel to our special section names.
> This patch implements his idea.
>
> ppc and v850 are dropped per comments from arch people.
> parisc and x86 had minor fixes. x86 fix added proper
> executable bits to a section:
>
> -.section ".text.head"
> +.section ".kernel.text.head","ax",@progbits
>
> Does arch/m68k/kernel/sun3-head.S need the same fix?
>
> The patch is run-tested on x86_64.
>
> I would like to ask arch maintainers to ACK/NAK this patch,
> and Andrew to act accordingly.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

could you please put the ax/progbits fix in front of the queue so that
it becomes bisectable and so that the later patches keep their "it
should not change anything" property?

I.e. do not mix small fixlets into a large set of "no change" patches -
split them out in front. This is really important for the x86 bits as
linker script changes tend to be quite fragile.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/