PATCH] firewire: add padding to some struct

From: JiSheng Zhang
Date: Fri Jul 18 2008 - 05:06:39 EST


>From JiSheng Zhang <jszhang3@xxxxxxxxxxxxxxxx>

struct fw_cdev_event_response and struct fw_cdev_event_iso_interrupt need padding.
Otherwise, offset of the zero length array is not equal to the struct size. It may
cause some strange problems under some platforms such as sparc32. This
patch(against 2.6.26) should fix it.


--- old/include/linux/firewire-cdev.h 2008-07-18 16:34:01.181794046 +0800
+++ new/include/linux/firewire-cdev.h 2008-07-18 16:35:46.649294275 +0800
@@ -92,6 +92,7 @@
__u32 type;
__u32 rcode;
__u32 length;
+ __u32 pad;
__u32 data[0];
};

@@ -143,6 +144,7 @@
__u32 type;
__u32 cycle;
__u32 header_length;
+ __u32 pad;
__u32 header[0];
};



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/