Re: [PATCH] coredump: kill mm->core_done

From: Roland McGrath
Date: Sat Jul 19 2008 - 23:20:31 EST


It is indeed ugly. I think the place to start is with moving all the
coredump code out of exit_mm() into a new subfunction that is just passed
the mm pointer, and doing the same with coredump_finish() as you've done,
but leaving the completion logic inside those functions the same. If all
references to the core_* fields in mm_struct are inside coredump_*()
functions, then that is a good basis for the future cleanups.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/