Re: [PATCH] x86: PIC, L-APIC and I/O APIC debug information
From: Mikael Pettersson
Date: Sun Jul 20 2008 - 20:37:30 EST
Maciej W. Rozycki writes:
> Dump all the PIC, local APIC and I/O APIC information at the
> fs_initcall() level, which is after ACPI (if used) has initialised PCI
> information, making the point of invocation consistent across MP-table and
> ACPI platforms. Remove explicit calls to print_IO_APIC() from elsewhere.
> Make the interface of all the functions involved consistent between 32-bit
> and 64-bit versions and make them all static by default by the means of a
> New-and-Improved(TM) __apicdebuginit() macro.
> +#define __apicdebuginit(type) static type __init
> -void __init print_IO_APIC(void)
> +__apicdebuginit(void) print_IO_APIC(void)
I _really_ dislike how this abuses the C macro preprocessor
to create pointless new syntax.
Since you're editing these function definitions anyway why
not just spell out "static void __init" in readable proper C?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/