[PATCH] b43legacy: Release mutex in error handling code

From: Michael Buesch
Date: Mon Jul 21 2008 - 05:30:31 EST

From: Julia Lawall <julia@xxxxxxx>

The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.

The semantic patch finds this problem is as follows:

// <smpl>
expression l;

... when != mutex_unlock(l)
when any
when strict
if (...) { ... when != mutex_unlock(l)
+ mutex_unlock(l);
return ...;
// </smpl>

Signed-off-by: Julia Lawall <julia@xxxxxxx>
Signed-off-by: Michael Buesch <mb@xxxxxxxxx>
Cc: stable <stable@xxxxxxxxxx>


John, please apply this bugfix to the next bugfix release.

diff -u -p a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
--- a/drivers/net/wireless/b43legacy/main.c
+++ b/drivers/net/wireless/b43legacy/main.c
@@ -3862,10 +3862,10 @@ static int b43legacy_resume(struct ssb_d
goto out;
- mutex_unlock(&wl->mutex);

b43legacydbg(wl, "Device resumed.\n");
+ mutex_unlock(&wl->mutex);
return err;

Greetings Michael.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/