Re: [PATCH 1/2] x86: rename PTE_MASK to PTE_PFN_MASK

[Jeremy Fitzhardinge]

Johannes Weiner wrote:
> PTE_PFN_MASK is not symmetric to PAGE_MASK.

No, it isn't.  Is there anything about the name that suggests that it 
should be?  PTE_PFN_MASK is for operating on pteval_t-typed values 
extracted from ptes; PAGE_MASK is for operating on addresses.

>   How about PTE_PROT_MASK?
>   

That's the opposite sense; the next patch defines it as PTE_FLAGS_MASK.

   J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/