Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus upon pci_scan_child_bus()

From: Eran Liberty
Date: Tue Jul 22 2008 - 11:29:00 EST

Matthew Wilcox wrote:
If this is all alone on a bus of its own, we can certainly handle that.
Maybe we can make it a module parameter or something.
If my devices where the only one on the bus I would not have stumbled on this bug. I would have removed them all before reloading and would have scanned and empty PCI bus list after the reloading.

Alas, the CPU itself is a pci device. Upon scanning the bus it is it who is duplicated. Upon trying to "pci_bus_add_devices()" you get resource collision.

Do you perceive any down side to my suggested patch?
It seems (to me) really logical that a device can not and should not be added twice to a pci bus device list.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at