Re: [PATCH 72/79] sysdev: Pass the attribute to the low levelsysdev show/store function

From: Greg KH
Date: Tue Jul 22 2008 - 16:52:46 EST

On Tue, Jul 22, 2008 at 01:40:45PM -0700, Andrew Morton wrote:
> On Mon, 21 Jul 2008 22:19:36 -0700
> Greg Kroah-Hartman <gregkh@xxxxxxx> wrote:
> > From: Andi Kleen <andi@xxxxxxxxxxxxxx>
> >
> > This allow to dynamically generate attributes and share show/store
> > functions between attributes. Right now most attributes are generated
> > by special macros and lots of duplicated code. With the attribute
> > passed it's instead possible to attach some data to the attribute
> > and then use that in shared low level functions to do different things.
> >
> > I need this for the dynamically generated bank attributes in the x86
> > machine check code, but it'll allow some further cleanups.
> >
> > I converted all users in tree to the new show/store prototype. It's a single
> > huge patch to avoid unbisectable sections.
> >
> > Runtime tested: x86-32, x86-64
> > Compiled only: ia64, powerpc
> > Not compile tested/only grep converted: sh, arm, avr32
> >
> > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >
> > ...
> >
> > kernel/sched.c | 8 ++++-
> This wrecks use-sysdev_class-in-schedc.patch (below), which I merged a
> week ago and will now drop.
> Why did this patch from Andi just turn up in linux-next now, halfway
> through the merge window? It has a commit date of July 1 yet it has
> never before been sighted in linux-next.

What? It's been in linux-next for a while now as it's been in my tree
for quite some time. Unless it somehow got reverted in -next and I
didn't realize it? Which I kind of doubt as it was causing problems
with the sparc build and I got reports of that.

This should be a simple merge, the show/store functions of sysdev now
just got an additional parameter, like we've done for a while with other
types of attributes.


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at