Re: [PATCH 1/8] cpumask: Replace cpumask_of_cpu with cpumask_of_cpu_ptr

From: Mike Travis
Date: Wed Jul 23 2008 - 10:27:10 EST


Ingo Molnar wrote:
> * Ingo Molnar <mingo@xxxxxxx> wrote:
>
>>> The simple version is just a static array of [NR_CPUS] cpumask_t's.
>>> Do that, with an override for smarter archs?
>>>
>>> I really REALLY prefer that over the fairly tortuous macros.
>> a fresh commit in -git has exposed the topology.h mess - see the hack
>> below. We now have diverging versions of topology_core_siblings()
>> semantics - that sure cannot be right. Mike?
>
> also i had to do the net/sunrpc/svc.c fixup below.
>
> Ingo
>
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index 5a32cb7..835d274 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -310,7 +310,8 @@ svc_pool_map_set_cpumask(struct task_struct *task, unsigned int pidx)
> switch (m->mode) {
> case SVC_POOL_PERCPU:
> {
> - set_cpus_allowed_ptr(task, &cpumask_of_cpu(node));
> + cpumask_of_cpu_ptr(cpumask, node);
> + set_cpus_allowed_ptr(task, cpumask);
> break;
> }
> case SVC_POOL_PERNODE:


I had sent in a patch that has this change.

Standby, the "generic" cpumask_of_cpu_map patch is coming... just testing now.

THanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/