Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open()

From: Jeremy Fitzhardinge
Date: Thu Jul 24 2008 - 14:39:42 EST


Jeff Garzik wrote:
Jeremy Fitzhardinge wrote:
Eduardo Habkost wrote:
xen-netfront was waking the queue before calling netif_start_queue(),
triggering the BUG_ON() on __netif_schedule().

Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
Ok,
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>

but Ingo, do you want to pick this up? You're gathering a collection of these patches anyway, or should we kick it over to Dave/Jeff?

J

---
drivers/net/xen-netfront.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 902bbe7..c749bdb 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
}
spin_unlock_bh(&np->rx_lock);
- xennet_maybe_wake_tx(dev);
+ netif_start_queue(dev);

This is clearly a net driver change, it should go this way...

OK, all your's.

J

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/