Re: [PATCH] x86 (64): make calibrate_APIC_clock() SMI-safe (take2)

From: Martin Wilck
Date: Fri Jul 25 2008 - 09:40:39 EST


I wrote:

I have to say that my simplified patch failed to do the calibration
correctly on our test system (the original patch worked well). Please
stay tuned, we are investigating this currently.

Please forget that. It was observed on an old "enterprise" kernel with which we are currently testing the backported patch with, and it was due to the fact that the initial counter value on that kernel was divided by APIC_DIVISOR (=16). The resulting initial counter value was too low in a "SMI flood" case, the counter could overlap. APIC_DIVISOR is no longer used in the current kernel.

Martin

--
Martin Wilck
PRIMERGY System Software Engineer
FSC IP ESP DEV 6

Fujitsu Siemens Computers GmbH
Heinz-Nixdorf-Ring 1
33106 Paderborn
Germany

Tel: ++49 5251 8 15113
Fax: ++49 5251 8 20209
Email: mailto:martin.wilck@xxxxxxxxxxxxxxxxxxx
Internet: http://www.fujitsu-siemens.com
Company Details: http://www.fujitsu-siemens.com/imprint.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/