Re: [PATCH 2/5] drivers/scsi/aic94xx/: replace __FUNCTION__ with__func__

From: Darrick J. Wong
Date: Fri Jul 25 2008 - 16:11:45 EST


On Sat, Jul 26, 2008 at 01:08:38AM +0800, rae l wrote:
> On Sat, Jul 26, 2008 at 12:42 AM, Darrick J. Wong <djwong@xxxxxxxxxx> wrote:
> > On Fri, Jul 25, 2008 at 10:48:33AM +0800, Denis ChengRq wrote:
> >> Signed-off-by: Denis ChengRq <crquan@xxxxxxxxx>
> >
> > No justification or changelog?
> I think no more explanation needed, the subject is definite.
>
> and no justification happened here, (there are justifications otherwhere)

It's not clear to _me_ the _reason_ for changing this. I think you're
trying to implement C99 cleanups, but I don't know for sure and this is
the first I've heard of __FUNCTION__ -> __func__ changes.

Really all I wanted was the two words "per C99" at the end of the title
so that I don't have a "Why the heck did we change this?" moment six
months from now. :)

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/