Re: [PATCH] usb: don't hide bios bug warning

From: Yinghai Lu
Date: Sat Jul 26 2008 - 23:25:10 EST


On Sat, Jul 26, 2008 at 6:56 PM, David Brownell <david-b@xxxxxxxxxxx> wrote:
>> >> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
>> >> + dev_printk(KERN_WARNING, &pdev->dev,
>> >> + "EHCI: BIOS handoff failed"
>> >
>> > This is the exact same thing, no change.
>> >
>> > confused,
>>
>> end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.
>
> Yes it does ... KERN_WARNING != KERN_DEBUG, and it's the latter
> which is toggled (via DEBUG) by CONFIG_USB_DEBUG...

you are right,

please forget about the patch.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/