Re: [git pull] cpus4096 fixes

[Ingo Molnar]

* Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> On Monday 28 July 2008 05:06:01 Ingo Molnar wrote:
> > Linus,
> >
> > Please pull the latest cpus4096-fixes git tree from:
> >
> >    git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git
> > cpus4096
> >
> > this fixes the cpumask_of_cpu API fallout described here:
> >
> >    http://lkml.org/lkml/2008/7/23/76
> >
> > ... and the fix is wider than i'd like it to be, so close to -rc1
> 
> Sorry, it's wider because you pushed the last stupid Mike patch.  Over my 
> (obviously too-polite) objections.  Most of this is reverting that, just 
> without actually admitting it.
> 
> > - but it's the cleanest one and it has Rusty's ack as well.
> 
> Not really.  As authored, I intended it as a bandaid for systems with 
> small CPU numbers.  Mike made it always on (tho __initdata on large 
> x86 systems), which IMHO is insane (2MB of initdata?).

well, firstly, please understand that nobody is (and the least i am) 
blaming you for anything. I was the one who picked up the patch from 
Mike and sent it Linuswards so i'm to blame and it's me where the buck 
stops.

I have picked up a patch that you wrote originally that solved a problem 
that was first noticed due to crossing commits in the middle of -rc1, by 
drivers/net/sfc/efx.c aa6ef27ea9 which was authored 10 days ago and sent 
upstream 4 days after that - so there was no linux-next exposure where 
we could have noticed it. The cpumask API changes were in the works for 
months literally, and in linux-next for a long time.
 
That particular cpumask API breakage was dormant (read: nobody in-tree 
used the API as an lvalue up to commit aa6ef27ea9) and only got 
unearthed by that crossing change that made such (valid) use of the API. 
I'd have delayed it all and would have waited for the discussion to play 
out, hadnt it been for that (small) build breakage.
   
The 4 commits which were objected to by Linus were literally scrambled 
together in haste within 4 days, to solve that lvalue problem. And i 
Cc:-ed you on the pull request. If you disagree with or are unsure about 
patches you send out then please do not put a Signed-off-by into them 
but a Not-Yet-Signed-off-by. I _will_ notice that - and even if i dont 
notice it, my scripts will ;)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/