Re: [git pull] cpus4096 fixes

[Rusty Russell]

On Monday 28 July 2008 18:16:39 Ingo Molnar wrote:
> * Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> > Mike: I now think the right long-term answer is Linus' dense cpumap
> > idea + a convenience allocator for cpumasks.  We sweep the kernel for
> > all on-stack vars and replace them with one or the other.  Thoughts?
>
> The dense cpumap for constant cpumasks is OK as it's clever, compact and
> static.
>
> All-dynamic allocator for on-stack cpumasks ... is a less obvious
> choice.

Sorry, I was unclear.  "long-term" == "more than 4096 CPUs", since I thought 
that was Mike's aim.  If we only want to hack up 4k CPUS and stop, then I 
understand the current approach.

If we want huge cpu numbers, I think cpumask_alloc/free gives the clearest 
code.  So our approach is backwards: let's do that *then* put ugly hacks in 
if it's really too slow.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/