Re: [PATCH] add iommu_num_pages helper function

From: FUJITA Tomonori
Date: Tue Jul 29 2008 - 06:29:25 EST


On Tue, 29 Jul 2008 03:10:05 -0700 (PDT)
David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: Joerg Roedel <joerg.roedel@xxxxxxx>
> Date: Tue, 29 Jul 2008 11:50:27 +0200
>
> > I think moving that function to x86-only code is the best solution for
> > now. Before moving it back to generic code we need an architecture
> > independent way to find out the IOMMU page size.
>
> My suggestion (again) is to pass it in as a "const unsigned long
> io_page_size" argument and update the callers.

Either is fine by me.

Joerg, if you like, please finish this (for all the architectures,
please). As I said before, I planed to work on this cleanup after rc1
(and this should have been 2.6.28 stuff). But I'd appreciate if you
would do.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/