Re: RFC [PATCH] x86: introduce nr_irqs for 64bit

From: Yinghai Lu
Date: Wed Jul 30 2008 - 06:16:43 EST


On Wed, Jul 30, 2008 at 3:09 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
>
>> add DEFINE_DYN_ARRAY for dynamical array support
>>
>> todo:
>> 1. convert x86 32bit and other arch
>> 2. nr_irqs auto probe via acpi_oem_check?
>>
>> Signed-off-by: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
>
> wonderful!
>
> I have one main structural suggestion: could we please keep the NR_IRQS
> name, and just change it to dynamic on x86? NR_IRQS is used in 540
> places in the kernel, there's no point in touching all that code.
>
> Also add an CONFIG_ARCH_HAS_DYNAMIC_NR_IRQS switch, define it in
> arch/x86/Kconfig and use it in include/linux/irq.h.
>
> This will create far less migration pain than the widespread rename.
> That will also solve the "what about the other architectures" question.

just send out v2.

long term, i hope to make all arch to use nr_irqs and probe it
earlier. and kill NR_IRQS

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/