Re: [patch 2/4] vfs: filp is never NULL in do_generic_file_read()

From: KOSAKI Motohiro
Date: Thu Jul 31 2008 - 03:20:30 EST


> *ppos = ((loff_t)index << PAGE_CACHE_SHIFT) + offset;
> - if (filp)
> - file_accessed(filp);
> + file_accessed(filp);
> }
>
> int file_read_actor(read_descriptor_t *desc, struct page *page,

if filp is never NULL, BUG_ON is better?




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/