Re: [patch 0/4] [resend] Add configuration options to disablefeatures not needed on embedded devices

[David Woodhouse]

On Thu, 2008-07-31 at 02:40 -0700, David Miller wrote:
> From: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
> Date: Thu, 31 Jul 2008 11:27:03 +0200
> 
> > Changes since previous post:
> > 
> >  * Add Matt Mackall's Signed-off-by on all patches
> >  * Make bonding and bridging select ethtool in the ethtool-related
> >    patch.
> 
> The ethtool config option needs to be selected by CONFIG_INET as well,
> as per the things I described today.  Which erodes it's usefulness
> tremendously.
> 
> I also am keeping my stance that I have no current intention of
> applying these patches.

I would very much like you to reconsider, Dave.

We can make them default to 'y' and hide them behind CONFIG_EMBEDDED,
and put in a scary help text that tells people _never_ to turn it off --
and hell, you can even make a taint flag for it if you like. But there
are a lot of people who really don't need these features and really want
the option of leaving them out.

Perhaps we should add a warning printk when one of these features is
'required' but absent. That would help to make it clear when someone has
disabled a feature which they shouldn't have disabled.

Refusing to apply the patches just means that either those people will
get them from elsewhere, or that their kernel will be more bloated than
it needs to be.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/