Re: [PATCH] serial: change remove NR_IRQS in 8250.c

From: Eric W. Biederman
Date: Thu Jul 31 2008 - 07:53:19 EST


> replace
> [PATCH] serial: change irq_lists to use dyn_array
> use small array with index to handle irq locking for serial port
> hope 32 slot is enough

Could you size this array by NR_UARTS (our worst case usage)
and place irq_no in struct irq_info?

Also you want to hold irq_info->lock when you set or clear irq_no.
Just to be on the safe side. I expect we can avoid clearing the irq_no
in the irq_lists and prevent a few more races from being a possibility.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/