RE: [PATCH] cciss: return -EFAULT if copy_from_user() fails

[Miller, Mike (OS Dev)]

> -----Original Message-----
> From: Nikanth Karthikesan [mailto:knikanth@xxxxxxx]
> Sent: Thursday, July 31, 2008 1:06 AM
> To: Miller, Mike (OS Dev)
> Cc: ISS StorageDev; Jens Axboe
> Subject: [PATCH] cciss: return -EFAULT if copy_from_user() fails
>
> Return -EFAULT instead of -ENOMEM if copy_from_user() fails.
>
> Signed-off-by: Nikanth Karthikesan <knikanth@xxxxxxx>

Acked-by: Mike Miller <mike.miller@xxxxxx>

>
> ---
>  drivers/block/cciss.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/drivers/block/cciss.c
> ===================================================================
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1134,7 +1134,7 @@ static int cciss_ioctl(struct inode *ino
>                                 if
> (ioc->Request.Type.Direction == XFER_WRITE) {
>                                         if (copy_from_user
>                                             (buff[sg_used],
> data_ptr, sz)) {
> -                                               status = -ENOMEM;
> +                                               status = -EFAULT;
>                                                 goto cleanup1;
>                                         }
>                                 } else {
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/