Re: [PATCH 1/2] pata_legacy: export functionality to ide

From: Alan Cox
Date: Sun Aug 03 2008 - 08:16:48 EST


On Sun, 3 Aug 2008 09:37:56 +0200
Borislav Petkov <petkovbb@xxxxxxxxxxxxxx> wrote:

> Ok, here's a definitely better solution:

Please don't stuff large important pieces of code in header files where
they will be overlooked

NAK this.

I'm happy to have a shared library directory for ATA stuff, containing
useful C code, but hiding stuff in headers like that is just plain wrong.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/