Re: [PATCH] Introduce down_try() so we can move away fromdown_trylock()

From: Linus Torvalds
Date: Sun Aug 03 2008 - 13:34:41 EST




On Sun, 3 Aug 2008, Rusty Russell wrote:
>
> I love your suggestion tho. Oh wait, you didn't make one...

Ok, Rusty, I'm not bothering with this thread any more.

I gave a suggestion.

You didn't like it. Go away.

> And so my patch series replaces all 21 of them. It's a trivial replace,
> unlike sem -> mutex.

Your series doesn't "replace" anything.

It renames things with no good reason. The end result is _worse_. I told
you why. You don't like it.

> > Guys, some quality control and critical thinking, please.
>
> Good idea. If we'd done that we wouldn't have the down_trylock() brain
> damage.

You don't see the difference between "new crap" and "legacy crap that
people have historical reasons for and that people have learnt to live
with"?

Anyway, I NAK'ed your patches. Deal with it.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/