Re: [PATCH] Remove warning 'unused variable battery' in drivers/acpi/sbs.c

[Randy.Dunlap]

On Sun, 3 Aug 2008, Ilpo Järvinen wrote:

> On Sun, 3 Aug 2008, Manish Katiyar wrote:
> 
> > Below patch removes the following warning:
> > drivers/acpi/sbs.c: In function 'acpi_battery_remove':
> > drivers/acpi/sbs.c:819: warning: unused variable 'battery'
> > 
> > 
> > 
> > Signed-off-by:- "Manish Katiyar" <mkatiyar@xxxxxxxxx>
> > 
> > ---
> >  drivers/acpi/sbs.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
> > index 10a3651..8493603 100644
> > --- a/drivers/acpi/sbs.c
> > +++ b/drivers/acpi/sbs.c
> > @@ -816,7 +816,9 @@ static int acpi_battery_add(struct acpi_sbs *sbs, int id)
> > 
> >  static void acpi_battery_remove(struct acpi_sbs *sbs, int id)
> >  {
> > +#ifdef CONFIG_ACPI_SYSFS_POWER || CONFIG_ACPI_PROCFS_POWER
> 
> I don't think you can use || operator in ifdef like that... ...Try
> #if defined(...) || (...) instead.


Did the patch sumbitter try to build this with the patch in place???

-- 
~Randy