Re: [PATCH] cpuset: Add comments for update_domain_attr_tree

[Paul Menage]

On Thu, Jul 31, 2008 at 12:42 AM, Lai Jiangshan <laijs@xxxxxxxxxxxxxx> wrote:
>
> This patch was reviewed by Li Zefan and was revised on his suggestion before sent.
> Thanks Li Zefan.
>
> Reviewed-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
>
> Lai Jiangshan wrote:
>> Add comments for update_domain_attr_tree().
>>
>> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
>> ---
>> diff --git a/kernel/cpuset.c b/kernel/cpuset.c
>> index adf66c0..fed1f42 100644
>> --- a/kernel/cpuset.c
>> +++ b/kernel/cpuset.c
>> @@ -487,15 +487,21 @@ update_domain_attr(struct sched_domain_attr *dattr, struct cpuset *c)
>>  {
>>       if (dattr->relax_domain_level < c->relax_domain_level)
>>               dattr->relax_domain_level = c->relax_domain_level;
>> -     return;
>>  }
>>
>> +/*

If you're going to add a comment block, maybe it's worth making it
docbook-compatible? So /** at the start, and then following the proper
docbook style conventions in kernel-doc-nano-HOWTO.txt ?

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/